Add mysqld_exporter and podman-exporter image overrides#3856
Conversation
|
Skipping CI for Draft Pull Request. |
vyzigold
force-pushed
the
telemetry-forks
branch
from
66a7101 to
5dc4395
Compare
vyzigold
force-pushed
the
telemetry-forks
branch
from
5dc4395 to
65d309c
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/60d1514b53b6415e94aaec21a9944d19 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 15m 44s |
|
This PR is stale because it has been for over 15 days with no activity. |
|
mate.. I'll come back to this, don't auto-close :D |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 51m 25s |
vyzigold
force-pushed
the
telemetry-forks
branch
2 times, most recently
from
0adfb93 to
3242669
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 28m 13s |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 27m 16s |
|
recheck host-unreachable |
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 5m 04s |
|
recheck |
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 4m 10s |
|
recheck reposetup download timeout |
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 4m 30s |
| cifmw_update_containers_openstack | bool) or | ||
| (cifmw_update_containers_watcher is defined and | ||
| cifmw_update_containers_watcher | bool)) | ||
| cifmw_update_containers_watcher | bool) or |
There was a problem hiding this comment.
I don't know if changing condition here is necessary if just cifmw_update_containers_openstack is not enough.
There was a problem hiding this comment.
That makes sense 🤔 . I'll update the PR 👍
michburk
left a comment
michburk
left a comment
There was a problem hiding this comment.
lgtm but similar vars to those added here (e.g. cifmw_update_containers_ceilometersgcoreImage, cifmw_update_containers_edpmnodeexporterimage, etc. ) have entries in the update_containers role readme. New entries in the readme would be greatly appreciated 👍
|
Thanks for noticing. I'll add them 👍 |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 35m 25s |
|
recheck |
|
I just noticed, that the PR I used to test this infrawatch/feature-verification-tests#345 now silently reverted to using mysqld_exporter and podman-exporter images from quay, so this PR doesn't work anymore. I think the cause is the suggested change to the condition in edpm_prepare. Reading the condition thoroughly now (now meaning without changing it in this PR), I'd need to set either "cifmw_update_containers_openstack" or "cifmw_update_containers_watcher" or "cifmw_update_containers_ansibleee_image_url" or "cifmw_update_containers_edpm_image_url" to true in order to execute the update_containers role and I don't think it makes sense to require to set either of these to true in order to update these images. So I'll add the "cifmw_update_containers_ceilometermysqldexporterImage is defined" etc back into the condition. I'll set this PR as draft until I can confirm I'm able to get the containers successfully updated in the test PR again. |
…rrides Add ceilometerMysqldExporterImage and edpmPodmanExporterImage fields to the update_containers template. This allows Zuul content-provider jobs for mysqld_exporter and prometheus-podman-exporter to override the container images used in functional tests via the OpenStackVersion custom resource. Generated-By: Claude-Code claude-opus-4-6 Signed-off-by: Jaromir Wysoglad <jwysogla@redhat.com>
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 30m 16s |
3 participants
Add ceilometerMysqldExporterImage and edpmPodmanExporterImage fields to the update_containers template. This allows Zuul content-provider jobs for mysqld_exporter and prometheus-podman-exporter to override the container images used in functional tests via the OpenStackVersion custom resource.
Generated-By: Claude-Code claude-opus-4-6